Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 03/06/2024 19:18, Jan Kara wrote:
On Mon 03-06-24 09:48:34, Youling Tang wrote:
From: Youling Tang <tangyouling@xxxxxxxxxx>

After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
in this file needs anything from `linux/prefetch.h`.

Signed-off-by: Youling Tang <tangyouling@xxxxxxxxxx>
Sorry to bother you, but do we still need this patch?

Thanks,
Youling.

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

---
  fs/direct-io.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index b0aafe640fa4..bbd05f1a2145 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -37,7 +37,6 @@
  #include <linux/rwsem.h>
  #include <linux/uio.h>
  #include <linux/atomic.h>
-#include <linux/prefetch.h>
#include "internal.h" @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
  	struct blk_plug plug;
  	unsigned long align = offset | iov_iter_alignment(iter);
- /*
-	 * Avoid references to bdev if not absolutely needed to give
-	 * the early prefetch in the caller enough time.
-	 */
-
  	/* watch out for a 0 len io from a tricksy fs */
  	if (iov_iter_rw(iter) == READ && !count)
  		return 0;
--
2.34.1






[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux