On Wed, Jul 17, 2024 at 04:24:28PM +0100, John Garry wrote: >>>> new logic to it this might indeed be a good time. >>> ok, I'll see if can come up with something >> I can take a look too. > > I was wondering what you plans are for any clean-up/refactoring here, as > mentioned? Try to split all the convert left over of large rtextent / allocation size logic out of __xfs_bunmapi and into a separate helper or two. I started on it after writing that previous mail, but it has been preempted by more urgent work for now. > I was starting to look at the whole "if (forcealign) else if (big rt)" flow > refactoring in this series to use xfs_inode_alloc_unitsize(); however, I > figure that you have plans wider in scope, which affects this. It will create a bit of conflict, but nothing out of ordinary.
