On Tue, Jul 09, 2024 at 04:30:18AM +0100, Matthew Wilcox (Oracle) wrote: > + struct folio *folio = read_mapping_folio(mapping, n, NULL); > + > + if (IS_ERR(folio)) > + return &folio->page; return ERR_CAST(folio); would be better here; yes, I realize it's going away in the next commit, but it's easier to follow that way (and actually makes the next commit easier to follow as well).