On Tue, Jul 9, 2024, at 16:23, Jeff Layton wrote:
> On Tue, 2024-07-09 at 16:16 +0200, Arnd Bergmann wrote:
>> On Tue, Jul 9, 2024, at 15:45, Geert Uytterhoeven wrote:
>
> I think the simplest solution is to make the floor value I'm tracking
> be an atomic64_t. That looks like it should smooth over the differences
> between arches. I'm testing a patch to do that now.
Yes, atomic64_t should work, but be careful about using this
in a fast path since it can turn into a global spinlock
in lib/atomic64.c on architectures that don't support it
natively.
I'm still reading through the rest of your series, but
it appears that you pass the time value into
ktime_to_timespec64() directly afterwards, so I guess
that is already a fairly large overhead on 32-bit
architectures and an extra spinlock doesn't hurt too
much.
Two more things I noticed in your patch:
- smp_load_acquire() on a 64-bit variable seems problematic
as well, maybe this needs a spinlock on 32-bit
architectures?
- for the coarse_ctime function, I think you should be
able to avoid the conversion to timespec by just calling
ktime_get_coarse_real_ts64() again instead of converting
monotonic to real and then to timespec.
- inode_set_ctime_current() seems to now store a fine-grained
timespec in the inode even for the !is_mgtime case, skipping
the timestamp_truncate() step. This appears to potentially
leak a non-truncated value to userspace, which would be
inconsistent with the value read back from disk.
Arnd
