Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 9 Jul 2024 13:19:46 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, John Garry <john.g.garry@xxxxxxxxxx>, chandan.babu@xxxxxxxxxx, djwong@xxxxxxxxxx, dchinner@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, jack@xxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, catherine.hoang@xxxxxxxxxx, martin.petersen@xxxxxxxxxx
In-reply-to: <Zo0JghFEaqxBs41l@dread.disaster.area>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jul 09, 2024 at 07:57:22PM +1000, Dave Chinner wrote:
> No code should be doing "if (forcealign) ... else if (realtime) ..."
> branching for alignment purposes. All the code should all be
> generic based on the value xfs_inode_alloc_unitsize() returns.

Yes, please.

References:
- [PATCH v2 00/13] forcealign for xfs
  - From: John Garry
- [PATCH v2 10/13] xfs: Unmap blocks according to forcealign
  - From: John Garry
- Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign
  - From: Christoph Hellwig
- Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign
  - From: Dave Chinner

Prev by Date: [PATCH 2/2] virtio-fs: Document 'file' mount option
Next by Date: Re: [PATCH v2 7/7] tools: add skeleton code for userland testing of VMA logic
Previous by thread: Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign
Next by thread: [PATCH v2 12/13] xfs: Don't revert allocated offset for forcealign
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]