> > > > > > There are other users of ZERO_PAGE, most notably in fs/direct-io.c and > > > block/blk-lib.c. Any chance to make this available to them? > > > > Please, no. > > > > We need to stop feature creeping this patchset and bring it to a > > close. If changing code entirely unrelated to this patchset is > > desired, please do it as a separate independent set of patches. > > > Agree; it was a suggestion only. I was going to say the same thing that Dave said as well as we are almost there with this series :) But I will add your suggestion in my TODO. It would be good to have some common infra to avoid allocating larger zero pages all over the place. > > Pankaj, you can add my: > > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Thanks Hannes.