On Thu, Jul 04, 2024 at 04:37:30AM +0100, Matthew Wilcox wrote:
> On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote:
> > + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o",
> > + MAJOR(__entry->dev), MINOR(__entry->dev),
> > + (unsigned long) __entry->ino,
> > + (unsigned long) __entry->dir, __entry->mode)
>
> erofs and f2fs are the only two places that print devices like this.
>
> "dev=%d:%d inode=%lx"
"dev %d:%d inode %lx"
i.e. every token in the output should be space separated, and no
commas between values.
Any other format makes it difficult for post processing tracepoint
output with sed, grep, awk, python, etc. Every token then has to be
split into name and value parts, and then the value has to have the
comma stripped from it.
Having to do this is additional work when writing use-once scripts
that get thrown away when the tracepoint output analysis is done
is painful, and it's completely unnecessary if the tracepoint output
is completely space separated from the start.
-Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
