On Wed, 3 Jul 2024 at 11:48, Xi Ruoyao <xry111@xxxxxxxxxxx> wrote: > > Fortunately LoongArch ILP32 ABI is not finalized yet (there's no 32-bit > kernel and 64-bit kernel does not support 32-bit userspace yet) so we > can still make it happen to use struct statx as (userspace) struct > stat... Oh, no problem then. If there are no existing binaries, then yes, please do that, It avoids the compat issues too. I think 'struct statx' is a horrid bloated thing (clearing those extra "spare" words is a pain, and yes, the user copy for _regular_ 'stat()' already shows up in profiles), but for some new 32-bit platform it's definitely worth the pain just to avoid the compat code or new structure definitions. Linus