[PATCH V2 0/3] fat: convert to the new mount API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This short series converts the fat/vfat/msdos filesystem to use the
new mount API.

V2 addresses the issues raised with the 2nd patch in the first series,
details are in patch this time.

I've tested it with a hacky shell script found at 

https://gist.github.com/sandeen/3492a39c3f2bf16d1ccdd2cd1c681ccd

which tries every possible option, including some with invalid values,
on both vfat and msdos mounts. It then tests random combinations of
2, 3, and 4 options, including possibly invalid options.

I captured stdout from two runs with and without these modifications,
and the results are identical.

As patch 2 notes, I left codepage loading to fill_super(), rather than
validating codepage options as they are parsed. This is because i.e.

mount -o "iocharset=nope,iocharset=iso8859-1"

passes today, due to the last iocharset option being the only one that is
loaded. It might be nice to validate such options as they are parsed, but
doing so would make the above command line fail, so I'm not sure if it's
a good idea. I do have a patch to validate as we parse, if that's desired.

Lastly, the 3rd patch converts to use the new uid/gid helpers as proposed
at https://lore.kernel.org/linux-fsdevel/8dca3c11-99f4-446d-a291-35c50ed2dc14@xxxxxxxxxx/T/#t
but feel free to squash patches 2 and 3 if you prefer.

Thanks,
-Eric





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux