On Mon, Jul 01, 2024 at 10:35:07PM +1000, Dave Chinner wrote: > Sorry, but I don't really care what either John or Christoph say on > this matter: xfs_inode_has_bigrtalloc() is recently introduced > technical debt that should not be propagated further. So send a patch to fix it. > xfs_inode_has_bigrtalloc() needs to be replaced completely with > xfs_inode_alloc_unitsize() and any conditional behaviour needed can > be based on the return value from xfs_inode_alloc_unitsize(). That > works for everything that has an allocation block size larger than > one filesystem block, not just one specific RT case. Only assuming we actually get these larger alloc sizes. Which right now we don't have, and to be honest I'm not sure they are a good idea. The whole larger alloc size thing has been a massive pain to deal with, and we'll need good argument for furthering that pain.
