Re: [PATCH] Fixes: ec16b147a55bfa14e858 ("fs: Fix rw_hint validation")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/24 8:21 PM, Hui Qi wrote:
The high 32 bits is filled with arbitrary value.

Which application does this? This is a user space bug. Additionally, the
patch title looks weird. Please improve the patch title.

If hint is set WRITE_LIFE_SHORT (2) by fcntl, the value is
0xf6d1374000000002,
This is a user space bug. The fcntl() man page clearly mentions that
F_SET_RW_HINT accepts a 64-bit value. See also
https://www.man7.org/linux/man-pages/man2/fcntl.2.html.

which causes rw_hint_valid always returns false. i_write_hint of inode and
bi_write_hint of bio are both enum rw_hint. The value would be truncated
only if the element value exceeds 2^32.

Signed-off-by: Hui Qi <hui81.qi@xxxxxxxxxxx>

If you want this patch to be merged you will have to add Fixes: and Cc:
stable tags.

Bart.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux