Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>
Subject: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 26 Jun 2024 07:22:38 +0200
Cc: Bart Van Assche <bvanassche@xxxxxxx>, Nitesh Shetty <nj.shetty@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, martin.petersen@xxxxxxxxxx, david@xxxxxxxxxxxxx, hare@xxxxxxx, damien.lemoal@xxxxxxxxxxxxxxxxxx, anuj20.g@xxxxxxxxxxx, joshi.k@xxxxxxxxxxx, nitheshshetty@xxxxxxxxx, gost.dev@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <05c7c08d-f512-4727-ae3c-aba6e8f2973f@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Jun 26, 2024 at 06:18:18AM +0900, Damien Le Moal wrote:
> 
> DM can deal with "abnormal" BIOs on its own. There is code for that.
> See is_abnormal_io() and __process_abnormal_io(). Sure, that will need more code
> compared to a bio sector+size based simple split, but I do not think it is a big
> deal given the potential benefits of the offloading.

It's not just dm.  You also need it in the partition remapping code
(mandatory), md (nice to have), etc.

And then we have the whole mess of what is in the payload for the I/O
stack vs what is in the payload for the on the wire protocol, which
will have different formatting and potentially also different sizes.

Follow-Ups:
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Bart Van Assche

References:
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Bart Van Assche
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Christoph Hellwig
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Bart Van Assche
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Christoph Hellwig
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Bart Van Assche
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Damien Le Moal
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Bart Van Assche
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Damien Le Moal

Prev by Date: Re: [PATCH v2 0/5] cachefiles: some bugfixes for clean object/send req/poll
Next by Date: posix_fallocate behavior in glibc
Previous by thread: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
Next by thread: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]