Re: [PATCH v2] vfs: Shortcut AT_EMPTY_PATH early for statx, and add AT_NO_PATH for statx and fstatat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 24, 2024 at 2:19 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
>
> On Mon, 2024-06-24 at 11:04 +0200, Mateusz Guzik wrote:
> > Below is a diff which compiles but is untested. It adds AT_EMPTY_PATH +
> > NULL as suggsted by Linus, but it can be adjusted for AT_NO_PATH (which
> > would be my preffered option, or better yet not do that and add fstatx).
> >
> > It does not do the hack to 0-check if a pointer was passed along with
> > AT_EMPTY_PATH but that again is an easy addition.
> >
> > Feel free to take without attribution:
>
> I'd still like to make it Co-developed-by: or just From: you.  Could you
> give a S-o-b?
>

I just trivially shuffled some things around and did not even test, so
I'm not signing off on squat here. :)

However, if you insist you can add something like "Written after
picking up an initial patch written by Mateusz Guzik, see [link goes
here]" or similar.

> And with this change AT_FDCWD with AT_EMPTY_PATH and NULL path does not
> work.  For consistency it'd be better to make it work too:
>

Good catch, I have no opinion which way to fix it.

-- 
Mateusz Guzik <mjguzik gmail.com>





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux