On Sun, Jun 23, 2024 at 10:29:30AM +0800, Yafang Shao wrote: > On Fri, Jun 21, 2024 at 9:57 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > > > On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > > > +++ b/mm/internal.h > > > > Why are you putting __kstrndup in a header file when it's only used > > in util.c? > > I want to make it always inlined. However, it is not recommended to > define an inline function in a .c file, right ? I'm not aware of any such recommendation. Better than putting it in a .h file that everybody has to look at but nobody uses.
