On 6/21/24 13:50, Kees Cook wrote:
Hi, This pair of patches replaces the last patch in this[1] series. Perform bprm argument overflow checking but only do argmin checks for MMU systems. To avoid tripping over this again, argmin is explicitly defined only for CONFIG_MMU. Thank you to Guenter Roeck for finding this issue (again)!
That does make me wonder: Is anyone but me testing, much less running, the nommu code in the kernel ? mps2-an385 trips over the same problem, and xtensa:nommu_kc705_defconfig doesn't even build in linux-next right now (spoiler alert: I suspect that the problem is caused by "kunit: test: Add vm_mmap() allocation resource manager", but I did not have time to bisect it). I am kind of tired keeping those tests alive, and I would not exactly shed tears if nommu support would just be dropped entirely. Guenter
