On Tue 18-06-24 16:19:37, Christian Brauner wrote: > > AFAICT this will have a side-effect that now fsnotify_open() will be > > generated even for O_PATH open. It is true that fsnotify_close() is getting > > Thanks! That change seemed sensible because a close() event is > generated. > > But I don't agree that generating events for O_PATH fds doesn't make > sense on principle. But I don't care if you drop events for O_PATH now. Well, I can be convinced otherwise but I was not able to find a compeling usecase for it. fanotify(8) users primarily care about file data modification / access events and secondarily also about directory content changes (because they change how data can be accessed). And creation of O_PATH fds does not seem to fall into either of these categories... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
