On Fri, Jun 07, 2024 at 02:59:50AM +0100, Al Viro wrote: > Calling conventions for __bpf_map_get() would be more convenient > if it left fpdut() on failure to callers. Makes for simpler logics > in the callers. > > Among other things, the proof of memory safety no longer has to > rely upon file->private_data never being ERR_PTR(...) for bpffs files. > Original calling conventions made it impossible for the caller to tell > whether __bpf_map_get() has returned ERR_PTR(-EINVAL) because it has found > the file not be a bpf map one (in which case it would've done fdput()) > or because it found that ERR_PTR(-EINVAL) in file->private_data of a > bpf map file (in which case fdput() would _not_ have been done). > > With that calling conventions change it's easy to switch all > bpffs users to CLASS(fd, ...) > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > --- Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
