Hello, I am trying to respin the series here : https://www.spinics.net/lists/linux-ext4/msg85081.html I resent some of the v9 patches and got some reviews from Gabriel, I did changes as requested and here is v18. Changes in v18: - in patch 2/7 removed the check for folded_name->len - in patch 4/7 simplified the use of generic_ci_match Changes in v17: - in patch 2/7 the case insensitive match helper, I modified the logic a bit, memcmp params, and return errors properly, also removed patches for logging errors as the message is now included in the helper itself. Changes in v16: - rewrote patch 2/9 without `match` - changed to return value in generic_ci_match coming from utf8 compare only in strict mode. - changed f2fs_warn to *_ratelimited in 7/9 - removed the declaration of f2fs_cf_name_slab in recovery.c as it's no longer needed. Changes in v15: - fix wrong check `ret<0` in 7/9 - fix memleak reintroduced in 8/9 Changes in v14: - fix wrong kfree unchecked call - changed the return code in 3/8 Changes in v13: - removed stray wrong line in 2/8 - removed old R-b as it's too long since they were given - removed check for null buff in 2/8 - added new patch `f2fs: Log error when lookup of encoded dentry fails` as suggested - rebased on unicode.git for-next branch Changes in v12: - revert to v10 comparison with propagating the error code from utf comparison Changes in v11: - revert to the original v9 implementation for the comparison helper. Changes in v10: - reworked a bit the comparison helper to improve performance by first performing the exact lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Gabriel Krisman Bertazi (7): ext4: Simplify the handling of cached casefolded names f2fs: Simplify the handling of cached casefolded names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/crypto.c | 10 +--- fs/ext4/ext4.h | 35 ++++++++----- fs/ext4/namei.c | 122 ++++++++++++++------------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 105 ++++++++++++-------------------------- fs/f2fs/f2fs.h | 16 +++++- fs/f2fs/namei.c | 10 ++-- fs/f2fs/recovery.c | 9 +--- fs/f2fs/super.c | 8 +-- fs/libfs.c | 74 +++++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 11 files changed, 195 insertions(+), 202 deletions(-) -- 2.34.1
