On Tue, Jun 04, 2024 at 06:40:59PM +0100, Al Viro wrote: > On Tue, Jun 04, 2024 at 10:35:43AM -0700, Ivan Babrou wrote: > > On Mon, Jun 3, 2024 at 8:40 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > ... when the only way to get to it is via ->getattr() in > > > proc_fd_inode_operations? Note that proc_fd_inode_operations > > > has ->lookup() in it; it _can't_ be ->i_op of a non-directory. > > > > > > Am I missing something here? > > > > It's been two years, but I think I was just extra cautious. > > Does anyone have objections against the following? > > [PATCH] proc_fd_getattr(): don't bother with S_ISDIR() check > > that thing is callable only as ->i_op->getattr() instance and only > for directory inodes (/proc/*/fd and /proc/*/task/*/fd) > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > --- Kill it, Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
