> +#ifndef rem_u64 > +static inline u32 rem_u64(u64 dividend, u32 divisor) > +{ > + if (is_power_of_2(divisor)) > + return dividend & (divisor - 1); > + return do_div(dividend, divisor); > +} > +#endif This ifndef seems superflous. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>