Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Nitesh Shetty <nj.shetty@xxxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>
Subject: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 24 May 2024 06:52:44 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, martin.petersen@xxxxxxxxxx, david@xxxxxxxxxxxxx, damien.lemoal@xxxxxxxxxxxxxxxxxx, anuj20.g@xxxxxxxxxxx, joshi.k@xxxxxxxxxxx, nitheshshetty@xxxxxxxxx, gost.dev@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <66503bc7.630a0220.56c85.8b9dSMTPIN_ADDED_BROKEN@mx.google.com>
User-agent: Mozilla Thunderbird

On 5/23/24 23:54, Nitesh Shetty wrote:

Regarding merge, does it looks any better, if we use single request
operation such as REQ_OP_COPY and use op_flags(REQ_COPY_DST/REQ_COPY_SRC)
to identify dst and src bios ?


I prefer to keep the current approach (REQ_COPY_DST/REQ_COPY_SRC) and to
use a more appropriate verb than "merge", e.g. "combine".

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Nitesh Shetty

References:
- [PATCH v20 00/12] Implement copy offload support
  - From: Nitesh Shetty
- [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Nitesh Shetty
- Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
  - From: Hannes Reinecke

Prev by Date: [GIT PULL] bcachefs fixes for 6.10-rc1
Next by Date: Re: [PATCH] debugfs: ignore auto and noauto options if given
Previous by thread: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
Next by thread: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]