On Mon, May 20, 2024 at 05:29:17PM +0200, Christoph Hellwig wrote: > This looks generally good. But a few nitpicks: > > - please split the mapping_max_folio_size addition into a separate > well-documented helper instead of merging it into the iomap change. Okay. Will do that in v4. > - judgment is a really weird term for code. Here is a subject I came > up with, which might not be perfect: > > "iomap: fault in smaller chunks for non-large folio mappings" > A better choice for me. Thanks, Xu Yang