Re: [PATCH v20 00/12] Implement copy offload support

To: Nitesh Shetty <nj.shetty@xxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH v20 00/12] Implement copy offload support
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Mon, 20 May 2024 15:54:15 -0700
Cc: martin.petersen@xxxxxxxxxx, david@xxxxxxxxxxxxx, hare@xxxxxxx, damien.lemoal@xxxxxxxxxxxxxxxxxx, anuj20.g@xxxxxxxxxxx, joshi.k@xxxxxxxxxxx, nitheshshetty@xxxxxxxxx, gost.dev@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20240520102033.9361-1-nj.shetty@samsung.com>
User-agent: Mozilla Thunderbird

On 5/20/24 03:20, Nitesh Shetty wrote:

4. This bio is merged with the request containing the destination info.


bios with different operation types must never be merged. From attempt_merge():

	if (req_op(req) != req_op(next))
		return NULL;

Thanks,

Bart.

References:
- [PATCH v20 00/12] Implement copy offload support
  - From: Nitesh Shetty