On Wed, 2009-10-07 at 17:07 +0800, Wu Fengguang wrote:
>
> > wakeup implies a full memory barrier.
>
> If so, this smp_mb__after_clear_bit() line is also not necessary?
>
> void clear_bdi_congested(struct backing_dev_info *bdi, int sync)
> {
> //...
> clear_bit(bit, &bdi->state);
> smp_mb__after_clear_bit();
> if (waitqueue_active(wqh))
> wake_up(wqh);
Depends on if the barrier is needed even when the wakeup doesn't happen
I guess ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
