Hi Kees, kernel test robot noticed the following build errors: [auto build test ERROR on kees/for-next/execve] [also build test ERROR on kees/for-next/pstore kees/for-next/kspp brauner-vfs/vfs.all linus/master v6.9 next-20240520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/exec-Avoid-pathological-argc-envc-and-bprm-p-values/20240520-101851 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/20240520021615.741800-1-keescook%40chromium.org patch subject: [PATCH 1/2] exec: Add KUnit test for bprm_stack_limits() config: i386-randconfig-004-20240520 (https://download.01.org/0day-ci/archive/20240520/202405202157.xE9dP8fI-lkp@xxxxxxxxx/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240520/202405202157.xE9dP8fI-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202405202157.xE9dP8fI-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): ld: fs/exec.o: in function `exec_test_bprm_stack_limits': >> fs/exec_test.c:98:(.text+0xdfc): undefined reference to `kunit_binary_assert_format' >> ld: fs/exec_test.c:98:(.text+0xe0c): undefined reference to `__kunit_do_failed_assertion' >> ld: fs/exec_test.c:99:(.text+0xe56): undefined reference to `kunit_binary_assert_format' ld: fs/exec_test.c:99:(.text+0xe66): undefined reference to `__kunit_do_failed_assertion' Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM_XE [=m] && DRM_XE [=m]=m vim +98 fs/exec_test.c 85 86 static void exec_test_bprm_stack_limits(struct kunit *test) 87 { 88 /* Double-check the constants. */ 89 KUNIT_EXPECT_EQ(test, _STK_LIM, SZ_8M); 90 KUNIT_EXPECT_EQ(test, ARG_MAX, 32 * SZ_4K); 91 92 for (int i = 0; i < ARRAY_SIZE(bprm_stack_limits_results); i++) { 93 const struct bprm_stack_limits_result *result = &bprm_stack_limits_results[i]; 94 struct linux_binprm bprm = result->bprm; 95 int rc; 96 97 rc = bprm_stack_limits(&bprm); > 98 KUNIT_EXPECT_EQ_MSG(test, rc, result->expected_rc, "on loop %d", i); > 99 KUNIT_EXPECT_EQ_MSG(test, bprm.argmin, result->expected_argmin, "on loop %d", i); 100 } 101 } 102 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
