On Tue, May 07, 2024 at 11:10:44AM -0400, Kent Overstreet wrote: > On Tue, May 07, 2024 at 10:43:11AM -0400, Kent Overstreet wrote: > > Hi Linus, another stack of fixes for you. > > I have a report from a user that the sb-downgrade validation has an > issue, so that's been yanked. As a followup: the sb-downgrade patch was good, the user had at some point been running an unreleased version (which adds new accounting for amount of unstriped data in stripe buckets); and that version generated a faulty downgrade entry (because it has custom logic for generating the downgrade entry based on whether erasure coding is in use). But I'm still holding that patch for now while I come up with something for that user's filesystem - I'll probably add a flags parameter to that validation code so that we only fail to validate if we're writing out something new, like we already can for bkeys.