On Sat, Apr 27, 2024 at 10:12:30PM +0100, Al Viro wrote: > We don't have bdev opened exclusive there. And I'm rather dubious > about the need to do set_blocksize() anywhere in btrfs, to be > honest - there's some access to page cache of underlying block > devices in there, but it's nowhere near the hot paths, AFAICT. > > In any case, btrfs_get_dev_args_from_path() only needs to read > the on-disk superblock and copy several fields out of it; all > callers are only interested in devices that are already opened > and brought into per-filesystem set, so setting the block size > is redundant for those and actively harmful if we are given > a pathname of unrelated device. > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > --- Looks good to me, Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
