On 2024/4/29 12:41, Christoph Hellwig wrote: > On Sun, Apr 28, 2024 at 11:26:00AM +0800, Zhang Yi wrote: >>> >>> Oh well. Given that we're full in on the speculative allocations >>> we might as well deal with it. >>> >> >> Let me confirm, so you also think the preallocations in the COW fork that >> overlaps the unreflinked range is useless, we should avoid allocating >> this range, is that right? If so, I suppose we can do this improvement in >> another patch(set), this one works fine now. > > Well, not stop allocating it, but not actually convert it to a real > allocation when we're just truncating it and replacing the blocks with > reflinked blocks. OK, it looks fine, too. Thanks, Yi. > > But yes, this is a bigger project.> > For now for this patch to go ahead: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
