On Sat, Apr 27, 2024 at 10:10:32PM +0100, Al Viro wrote: > 1) it doesn't make any sense to have ->open() call set_blocksize() on the > device being opened - the caller will override that anyway. > > 2) setting block size on underlying device, OTOH, ought to be done when > we are opening it exclusive - i.e. as part of pkt_open_dev(). Having > it done at setup time doesn't guarantee us anything about the state > at the time we start talking to it. Worse, if you happen to have > the underlying device containing e.g. ext2 with 4Kb blocks that > is currently mounted r/o, that set_blocksize() will confuse the hell > out of filesystem. I brought some of this before and didn't dare to touch it because I have no way of testing this code. The changes looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But I really wish we could find a dedicated tester for pktcdvd or just drop this code..
