On Fri, Apr 26, 2024 at 02:22:25PM +0530, Ritesh Harjani wrote: > Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > > > On Thu, Apr 25, 2024 at 06:58:49PM +0530, Ritesh Harjani (IBM) wrote: > >> If the extent spans the block that contains the i_size, we need to > > > > s/the i_size/i_size/. > > > >> handle both halves separately > > > > .. so that we properly zero data in the page cache for blocks that are > > entirely outside of i_size. > > Sure. > > > > > Otherwise looks good: > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Thanks for the review. With Christoph's comments addressed, you can also add Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > > -ritesh >
