Hi Al,
On 2024/4/26 03:56, Al Viro wrote:
On Fri, Apr 12, 2024 at 12:13:42AM +0800, Gao Xiang wrote:
...
Just saw this again by chance, which is unexpected.
Yeah, I think that is a good idea. The story is that erofs_bread()
was derived from a page-based interface:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/erofs/data.c?h=v5.10#n35
so it was once a page index number. I think a byte offset will be
a better interface to clean up these, thanks for your time and work
on this!
FWIW, see #misc.erofs and #more.erofs in my tree; the former is the
minimal conversion of erofs_read_buf() and switch from buf->inode
to buf->mapping, the latter follows that up with massage for
erofs_read_metabuf().
Completely untested; it builds, but that's all I can promise. Individual
patches in followups.
Thanks for so much time on this, I will review/test/feedback
these patches by the end of this week since an internal project
for my employer is also ongoing.
Thanks,
Gao Xiang
