Hi Al,
On 2024/4/26 04:08, Al Viro wrote:
On Thu, Apr 25, 2024 at 08:56:41PM +0100, Al Viro wrote:
FWIW, see #misc.erofs and #more.erofs in my tree; the former is the
minimal conversion of erofs_read_buf() and switch from buf->inode
to buf->mapping, the latter follows that up with massage for
erofs_read_metabuf().
First two and last four patches resp. BTW, what are the intended rules
for inline symlinks? "Should fit within the same block as the last
symlink on-disk layout follows the same rule of regular files. The last
logical block can be inlined right after the on-disk inode (called tail
packing inline) or use a separate fs block to keep the symlink if tail
packing inline doesn't fit.
byte of on-disk erofs_inode_{compact,extended}"? Feels like
erofs_read_inode() might be better off if it did copying the symlink
body instead of leaving it to erofs_fill_symlink(), complete with
the sanity checks... I'd left that logics alone, though - I'm nowhere
near familiar enough with erofs layout.
If I understand correctly, do you mean just fold erofs_fill_symlink()
into the caller? That is fine with me, I can change this in the
future.
Thanks,
Gao Xiang
