On Sat, Apr 20, 2024 at 03:50:22AM +0100, Matthew Wilcox (Oracle) wrote:
> The folio error flag is not checked anywhere, so we can remove the calls
> to set and clear it.
>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> Cc: Darrick J. Wong <djwong@xxxxxxxxxx>
> Cc: linux-xfs@xxxxxxxxxxxxxxx
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Looks fine to me,
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/iomap/buffered-io.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 4e8e41c8b3c0..41352601f939 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -306,8 +306,6 @@ static void iomap_finish_folio_read(struct folio *folio, size_t off,
> spin_unlock_irqrestore(&ifs->state_lock, flags);
> }
>
> - if (error)
> - folio_set_error(folio);
> if (finished)
> folio_end_read(folio, uptodate);
> }
> @@ -460,9 +458,6 @@ int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops)
> while ((ret = iomap_iter(&iter, ops)) > 0)
> iter.processed = iomap_readpage_iter(&iter, &ctx, 0);
>
> - if (ret < 0)
> - folio_set_error(folio);
> -
> if (ctx.bio) {
> submit_bio(ctx.bio);
> WARN_ON_ONCE(!ctx.cur_folio_in_bio);
> @@ -697,7 +692,6 @@ static int __iomap_write_begin(const struct iomap_iter *iter, loff_t pos,
>
> if (folio_test_uptodate(folio))
> return 0;
> - folio_clear_error(folio);
>
> do {
> iomap_adjust_read_range(iter->inode, folio, &block_start,
> @@ -1528,8 +1522,6 @@ iomap_finish_ioend(struct iomap_ioend *ioend, int error)
>
> /* walk all folios in bio, ending page IO on them */
> bio_for_each_folio_all(fi, bio) {
> - if (error)
> - folio_set_error(fi.folio);
> iomap_finish_folio_write(inode, fi.folio, fi.length);
> folio_count++;
> }
> --
> 2.43.0
>
>
