Re: [PATCH 02/30] btrfs: Use a folio in write_dev_supers()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2024 at 04:44:03PM +0200, David Sterba wrote:
> On Sat, Apr 20, 2024 at 03:49:57AM +0100, Matthew Wilcox (Oracle) wrote:
> > @@ -3812,8 +3814,7 @@ static int write_dev_supers(struct btrfs_device *device,
> >  		bio->bi_iter.bi_sector = bytenr >> SECTOR_SHIFT;
> >  		bio->bi_private = device;
> >  		bio->bi_end_io = btrfs_end_super_write;
> > -		__bio_add_page(bio, page, BTRFS_SUPER_INFO_SIZE,
> > -			       offset_in_page(bytenr));
> > +		bio_add_folio_nofail(bio, folio, BTRFS_SUPER_INFO_SIZE, offset);
> 
> Compilation fails when btrfs is built as a module, bio_add_folio_nofail()
> is not exported. I can keep __bio_add_page() and the conversion can be
> done later.

I'd rather you added the obvious patch I just sent ...

(please don't get me stuck in the infinite loop of "you can't export a
symbol without any users" "you can't add a user until this is exported")




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux