On Fri, 2009-09-04 at 16:51 +1000, npiggin@xxxxxxx wrote: > +static void file_list_lock_all(void) > +{ > + int i; > + int nr = 0; > + > + for_each_possible_cpu(i) { > + spinlock_t *lock; > + > + lock = &per_cpu(files_cpulock, i); > + spin_lock_nested(lock, nr); > + nr++; > + } > +} Same here, this'll make lockdep explode on >8-way. And create large spin times on large smp boxen. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html