On Thu 18-04-24 13:29:20, Matthew Wilcox wrote: > On Thu, Apr 18, 2024 at 12:50:00PM +0200, Jan Kara wrote: > > > - kaddr = kmap_local_page(page); > > > - memcpy(kaddr, iinfo->i_data + iinfo->i_lenEAttr, isize); > > > - memset(kaddr + isize, 0, PAGE_SIZE - isize); > > > - flush_dcache_page(page); > > > > So where did the flush_dcache_page() call go? AFAIU we should be calling > > flush_dcache_folio(folio) here, shouldn't we? > > > > > - SetPageUptodate(page); > > > - kunmap_local(kaddr); > > > + folio_fill_tail(folio, 0, iinfo->i_data + iinfo->i_lenEAttr, isize); > > > + folio_mark_uptodate(folio); > > > } > > It's inside folio_zero_tail(), called from folio_fill_tail(). Ah, missed that. Well hidden ;) Thanks for clarification. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
