On Thu, Apr 11, 2024 at 02:03:52PM +0300, Konstantin Komarov wrote: > On 04.04.2024 11:06, Linux regression tracking (Thorsten Leemhuis) wrote: > > On 25.03.24 13:05, Christian Brauner wrote: > >> On Mon, Mar 25, 2024 at 11:12:00AM +0100, Johan Hovold wrote: > >>> On Mon, Mar 25, 2024 at 09:34:38AM +0100, Christian Brauner wrote: > >>>> This causes visible changes for users that rely on ntfs3 to serve as an > >>>> alternative for the legacy ntfs driver. Print statements such as this > >>>> should probably be made conditional on a debug config option or similar. > >>>> > >>>> Cc: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > >>>> Cc: Johan Hovold <johan@xxxxxxxxxx> > >>>> Link: https://lore.kernel.org/r/Zf2zPf5TO5oYt3I3@xxxxxxxxxxxxxxxxxxxx > >>>> Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx> > >>> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > >>> > >>> I also see a > >>> > >>> ntfs3: Max link count 4000 > >>> > >>> message on mount which wasn't there with NTFS legacy. Is that benign > >>> and should be suppressed too perhaps? > >> We need a reply from the ntfs3 maintainers here. > There is no problem in suppressing the output of any messages during > mounting, like: > Messages like this: > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c > index eb7a8c9fba01..8cc94a6a97ed 100644 > --- a/fs/ntfs3/inode.c > +++ b/fs/ntfs3/inode.c > @@ -424,7 +424,6 @@ static struct inode *ntfs_read_mft(struct inode *inode, > if (names != le16_to_cpu(rec->hard_links)) { > /* Correct minor error on the fly. Do not mark inode as dirty. */ > - ntfs_inode_warn(inode, "Correct links count -> %u.", names); > rec->hard_links = cpu_to_le16(names); > ni->mi.dirty = true; > } > > can also be suppressed for the sake of seamless transition from a remote > NTFS driver. > However, I believe that file system corrections should be reported to > the user. A colleague of mine also tracked down a failed boot to the removal of the ntfs driver and reported seeing similar warnings with the ntfs3 driver. We're both accessing an NTFS partition on a Windows on Arm device, but it makes you wonder whether these warnings (corrections) are correct or indicative of a problem in the driver? Johan
