Simon Horman <horms@xxxxxxxxxx> wrote: > On Tue, Apr 02, 2024 at 09:32:37AM +0100, David Howells wrote: > > Simon Horman <horms@xxxxxxxxxx> wrote: > > > > > > + op->store.size = len, > > > > > > nit: this is probably more intuitively written using len; > > > > I'm not sure it makes a difference, but switching 'size' to 'len' in kafs is a > > separate thing that doesn't need to be part of this patchset. > > Sorry, I meant, using ';' rather than ',' at the end of the line. Ah, yes. That makes a lot more sense! David