On Tue, Apr 09, 2024 at 06:31:44PM -0500, John Groves wrote: > The ref vs. value logic used by sget_dev() was ungood, storing the > stack address of the key (dev_t) rather than the value of the key. > This straightens that out. > > In the sget_dev() path, the (void *)data passed to the test and set > helpers should be the value of the dev_t, not its address. > > Signed-off-by: John Groves <john@xxxxxxxxxx> > --- Afaict there's nothing wrong with the current logic so I'm missing your point here. It's casting to a dev_t and then dereferencing it. So I don't think this patch makes sense.
