Hi, There are still a few users of fops->read() in the core parts of the fs stack. Which is a shame, since it'd be nice to get rid of the non-iterator parts of down the line, and reclaim that part of the file_operations struct. Outside of moving in that direction as a cleanup, using ->read_iter() enables us to mark them with FMODE_NOWAIT. This is important for users like io_uring, where per-IO nonblocking hints make a difference in how efficiently IO can be done. Those two things are my main motivation for starting this work, with hopefully more to come down the line. All patches have been booted and tested, and the corresponding test cases from ltp have been run. Since v2: - Pass appropriate flags to get_unused_fd() and anon_inode_getfile(). Doesn't change anything, but it does convey more closely what each of them look at. - Add copy_to_iter_full() helper and use it for all conversions fs/signalfd.c | 44 ++++++++++++++++++++++++++++---------------- fs/timerfd.c | 33 +++++++++++++++++++++++---------- fs/userfaultfd.c | 44 ++++++++++++++++++++++++++++---------------- include/linux/uio.h | 10 ++++++++++ 4 files changed, 89 insertions(+), 42 deletions(-) -- Jens Axboe
