On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote: > On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@xxxxxxx> wrote: >> Frankly, this initializer is hard to understand for me. Why not simple: >> >> buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id; >> buf->f_fsid[1] = ORANGEFS_SB(sb)->id; >> > > +1 for this idea, seems easier to read for me. Yes, good idea, I'll send this as v2 after my next round of build testing. Arnd