On Wed, Apr 03, 2024 at 11:48:12PM +0200, David Hildenbrand wrote: > On 03.04.24 23:41, Kent Overstreet wrote: > > On Wed, Apr 03, 2024 at 02:12:40PM -0700, Nathan Chancellor wrote: > > > On Thu, Mar 21, 2024 at 09:36:23AM -0700, Suren Baghdasaryan wrote: > > > > From: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > > > > > > > The next patch drops vmalloc.h from a system header in order to fix > > > > a circular dependency; this adds it to all the files that were pulling > > > > it in implicitly. > > > > > > > > Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > > > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > > > Reviewed-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> > > > > > > I bisected an error that I see when building ARCH=loongarch allmodconfig > > > to commit 302519d9e80a ("asm-generic/io.h: kill vmalloc.h dependency") > > > in -next, which tells me that this patch likely needs to contain > > > something along the following lines, as LoongArch was getting > > > include/linux/sizes.h transitively through the vmalloc.h include in > > > include/asm-generic/io.h. > > > > gcc doesn't appear to be packaged for loongarch for debian (most other > > cross compilers are), so that's going to make it hard for me to test > > anything... > > The latest cross-compilers from Arnd [1] include a 13.2.0 one for > loongarch64 that works for me. Just in case you haven't heard of Arnds work > before and want to give it a shot. > > [1] https://mirrors.edge.kernel.org/pub/tools/crosstool/ Thanks for the pointer - but something seems to be busted with the loongarch build, if I'm not mistaken; one of the included headers references loongarch-def.h, but that's not included.