On Mon, Apr 1, 2024 at 11:21 PM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
>
>
>
> On 2024/4/2 2:22, Vishal Moola wrote:
> > On Thu, Mar 21, 2024 at 11:27:38AM +0800, Kefeng Wang wrote:
> >>
> >> if (!newpage) {
> >> @@ -728,14 +729,13 @@ static void __migrate_device_pages(unsigned long *src_pfns,
> >> continue;
> >> }
> >>
> >> - mapping = page_mapping(page);
> >> + newfolio = page_folio(newpage);
> >
> > You could save another compound_head() call by passing the folio through
> > to migrate_vma_insert_page() and make it migrate_vma_insert_folio(),
> > since its already converted to use folios.
>
> Sure, but let's do it later, we could convert more functions in
> migrate_device.c to use folios, thanks for your review, do you
Makes sense to me. This patch looks fine to me:
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@xxxxxxxxx>
> mind to help to review other patches, hope that the poison recover
> from migrate folio was merged firstly.
I'll take a look at it, I'm not too familiar with how that code works just
yet.
> >
> >> + folio = page_folio(page);
> >> + mapping = folio_mapping(folio);
> >>
> >
