On Mon, Sep 21, 2009 at 10:02, Al Viro wrote: > * blackfin cplbinfo: utter crap; it's used to decide which procfs file > is being opened - by dumping full pathname into a (on-stack) buffer > and then parsing it. Stupid *and* broken. it works without having to copy & paste the same exact structures over and over. a suggestion as how to do it cleanly without bloating the code is certainly welcome. it doesnt really matter that it's on the stack as the usage is small and d_path() is given the size of the buffer, so it isnt going to overflow. > * blackfin traps.c:decode_address(): for one thing, pathnames has been > known to be longer than 256 bytes. we know the paths are longer than 256 bytes. the output is to give a reasonable idea of what is crashing. realistically, nothing executable resides in a 256+ byte path on an embedded system. > For another... locking in that loop > over processes and VMAs of each looks very suspicios, while we are at it. we've reviewed it several times and exercised it in multiple ways. so unless you have a real idea of something being wrong, the code has been vetted heavily. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
