On Mon, 2009-09-21 at 11:03 +0100, Al Viro wrote: > On Fri, Sep 18, 2009 at 01:06:00PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Miklos Szeredi <mszeredi@xxxxxxx> > > > > Add two helpers that allow access to the seq_file's own buffer, but > > hides the internal details of seq_files. > > > > This allows easier implementation of special purpose filling > > functions. It also cleans up some existing functions which duplicated > > the seq_file logic. > > Nice, but I suspect that exporting those two would be the right thing. > That, or inlining them - we are not actually hiding anything here, seeing > that struct seq_file is declared right there in the seq_file.h. > > I'm certainly fine with these helpers and associated cleanup. Unless > somebody has realistic plans of actually hiding the seq_file implementation[1], > I'd simply inline those two in seq_file.h. Miklos? Updated patches coming up. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
