Hi, On Wed, Mar 27, 2024 at 6:48 PM Baoquan He <bhe@xxxxxxxxxx> wrote: > > Mark these buffers as __nonstring and use strtomem_pad. > > Thanks. > > I didn't build, wondering if '__nonstring' has to be set so that > strtomem_pad() can be used. I do not believe marking buffers as __nonstring is strictly a requirement. However, the documentation from string.h +302 says we should do it: /** * strtomem_pad - Copy NUL-terminated string to non-NUL-terminated buffer * * @dest: Pointer of destination character array (marked as __nonstring) ... and so does [1] ... "mark the destination buffer variable (or structure member) with the __nonstring attribute..." FWIW, this builds just fine without the __nonstring attribute but we should use it :) > > Thanks > Baoquan > [1] https://github.com/KSPP/linux/issues/90 Thanks Justin
