On Thu, Mar 28, 2024 at 09:13:23AM +0100, Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 09:06:43AM +0100, Christian Brauner wrote: > > > Why do we need to set any of these for directory operations now that > > > we have a clear choice? i.e. we can't mmap directories, and the rest > > > of these flags are for read() and write() operations which we also > > > can't do on directories... > > > > Yeah, I know but since your current implementation raises them for both > > I just did it 1:1: > > Yes, sticking to the 1:1 for this patch is probably a good idea. > But we should also fix this in a trivial follow on patch. I can > write it and add it to your series. Ok.