On Mon, Mar 25, 2024 at 8:12 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Thu, Mar 21, 2024 at 09:36:36AM -0700, Suren Baghdasaryan wrote: > > +++ b/include/linux/pgalloc_tag.h > > @@ -0,0 +1,78 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * page allocation tagging > > + */ > > +#ifndef _LINUX_PGALLOC_TAG_H > > +#define _LINUX_PGALLOC_TAG_H > > + > > +#include <linux/alloc_tag.h> > > + > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + > > +#include <linux/page_ext.h> > > + > > +extern struct page_ext_operations page_alloc_tagging_ops; > > +extern struct page_ext *page_ext_get(struct page *page); > > +extern void page_ext_put(struct page_ext *page_ext); > > Why are you duplicating theses two declarations? > > I just deleted them locally and don't see any build problems. tested with > x86-64 defconfig (full build), allnoconfig full build and allmodconfig > mm/ and fs/ (nobody has time to build allmodconfig drivers/) Ah, good eye! We probably didn't include page_ext.h before and then when we did I missed removing these declarations. I'll post a fixup. Thanks!
