On Thu, Mar 14, 2024 at 07:34:04PM +0900, Keiichi Watanabe wrote: > Since d_splice_alias returns NULL on error, we need to do NUL check > instead of IS_ERR. d_splice_alias() does *NOT* return NULL on error. Never did. Moreover, passing it a pointer to non-directory inode will definitely return NULL. So will passing it a pointer to directory inode that currently has no aliases. NAK.