On Fri, Mar 22, 2024 at 03:39:55PM +0100, Günther Noack wrote: > On Fri, Mar 22, 2024 at 08:48:29AM +0100, Mickaël Salaün wrote: > > It might be interesting to create a layout with one file of each type > > and use that for the IOCTL tests. > > We have already written these tests and we can keep them, but I think that we > only gain little additional confidence from testing non-device files. The > implementation is saying pretty directly that IOCTLs are permitted if the file > is not a character or block device, at the top of the file_ioctl hook. I don't > see much value in testing this even more exhaustively and would like to keep it > as it is for now. OK, let's keep them for now, it's easy to remove a patch/commit.
